Remove texture_multisampled_2d_array builtins #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type does not exist in WGSL.
alan-baker
approved these changes
May 19, 2021
alan-baker
added
the
wgsl resolved
kvark
approved these changes
May 19, 2021
|
@alan-baker did you want to talk about this more before proceeding? Sorry if I merged this too quickly! |
|
No, I consider the needs approval stage, needs editor approval is that not the right state? |
|
I always treated "Needs Approval" as related to the WG (or the WGSL subgroup). Editors can approve things by just reviewing them, they shouldn't need this label internally. |
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type does not exist in WGSL.