wgsl: add refract as a built-in function #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the refract into WGSL, which is already a built in function in GLSL, HLSL and MSL. Also correct a mistyping in the description of reflect.
|
A problem is that the Preview PR action fails saying that "HTTP Error: 429, Couldn't create channel on |
|
Please take a look, thanks! @dneto0 @kvark @kainino0x @Kangz |
kvark
approved these changes
Jul 6, 2021
kvark
approved these changes
Jul 6, 2021
|
I still get the |
jzm-intel
changed the title
Kangz
approved these changes
Jul 7, 2021
|
I think this is non-controversial enough that we can merge now. |
ben-clayton
added a commit
to ben-clayton/Tint
that referenced
this pull request
Jul 13, 2021
See: gpuweb/gpuweb#1901 Bug: tint:950 Change-Id: I6f00ab753a2ddf2374352ddf636e1abfebe86ba7 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/56777 Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the refract into WGSL, which is already a built in function in GLSL, HLSL and MSL. Please see #1087 (comment).
Also correct a mistyping in the description of reflect.
A problem is that while GLSL said "The type of I and N (the first two operands) must be a scalar or vector with a floating-point component type", HLSL said they must be "vector", rather than "scale or vector". The situation is the same for reflect.