[wgsl]: Remove scalar overloads of faceForward and reflect
#1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSL does not have scalar overloads for these, as they don't make much sense for scalars.
kvark
approved these changes
Jul 7, 2021
|
Do we need more people to give their approval on this, or are we good to land? FWIW, we briefly discussed this in the office hours today, and @litherum had no objections. But office hours are not for WG decisions. :) |
|
The informal agreement sound fine to me. |
ben-clayton
added a commit
to ben-clayton/Tint
that referenced
this pull request
Jul 13, 2021
These were removed from the spec in: gpuweb/gpuweb#1914 Bug: tint:921 Change-Id: I4e584fdee9cf540a192f12d1208595056e081410 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/57300 Auto-Submit: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: James Price <jrprice@google.com> Reviewed-by: James Price <jrprice@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSL does not have scalar overloads for these, as they have little practical use for scalar arguments.
Note: MSL also does not have scalar overloads for
distanceorlength, but these make some sense in scalar form, and might be useful if we supported generic / templated functions.