Disallow taking the address of a handle #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-baker
added
the
wgsl resolved
dneto0
requested changes
Jul 23, 2021
wgsl/index.bs
Outdated
| @@ -4511,6 +4511,9 @@ The <dfn noexport>address-of</dfn> operator converts a reference to its correspo | |||
| If |r| is an [=invalid memory reference=], then the resulting | |||
| pointer is also an invalid memory reference. | |||
|
|
|||
| It is a [=shader-creation error=] if |T| is type stored in the | |||
There was a problem hiding this comment.
Isn't it simpler to say |SC| must not be handle ?
And in https://gpuweb.github.io/gpuweb/wgsl/#module-scope-variables it says
If the store type is a texture type or a sampler type, then the variable declaration must not have a storage class decoration. The storage class will always be handle.
(In any case, I think the proposed text is missing "a", as in "is a type stored in the...")
kvark
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1832