-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify that filtering with comparison is implementation-defined #2425
Conversation
if we allow depth textures bound as regular float textures, we could still support linear sampling, couldn't we? |
Hm, I didn't think so, but maybe I'm missing something. According to #744 (comment), Vulkan doesn't allow reinterpreting depth formats. Also, I don't think we would know which view to use at createBindGroup time unless we can always use an R-only view? |
I realized I needed to actually update the associated algorithm to disallow filtering "depth" bindings. (#2094 to determine whether depth textures themselves can be used with "unfilterable-float" bindings.) |
And specify that comparison+filtering is always allowed, but non-comparison+filtering is never allowed. Investigation indicates this is the best we can support on Vulkan for any format. Fixes gpuweb#1266
9b104b4
to
4b85a62
Compare
oops, apparently the review from kvark was still valid for automerge. @toji PTAL anyway |
SHA: 371e040 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 371e040 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 371e040 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post-merge LGTM. :)
…web#2425) * Specify that filtering with comparison is implementation-defined And specify that comparison+filtering is always allowed, but non-comparison+filtering is never allowed. Investigation indicates this is the best we can support on Vulkan for any format. Fixes gpuweb#1266 * Only "float" texture bindings are filterable
And specify that comparison+filtering is always allowed, but non-comparison+filtering is never allowed. Investigation indicates this is the best we can support on Vulkan for any format.
Fixes #1266
Preview | Diff