Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the "internal" error type #3123

Merged
merged 9 commits into from Aug 31, 2022
Merged

Add the "internal" error type #3123

merged 9 commits into from Aug 31, 2022

Commits on Aug 31, 2022

  1. Adding the "operation" error type 

    Fixes #2308

This error type captures non-validation errors that occur at a system
or implementation level. (Such as shaders failing because they are
too complex.)
    @toji
    toji committed Aug 31, 2022
    Copy the full SHA
    fe20fbf View commit details
    Browse the repository at this point in the history

  2. Combined operation and OOM error, renamed to internal

    @toji
    toji committed Aug 31, 2022
    Copy the full SHA
    186e241 View commit details
    Browse the repository at this point in the history

  3. Apply Kai's suggestions from code review 

    Co-authored-by: Kai Ninomiya <kainino@chromium.org>
    @toji @kainino0x
    toji and kainino0x committed Aug 31, 2022
    Copy the full SHA
    2041cc4 View commit details
    Browse the repository at this point in the history

  4. Extend note with suggestion about smaller nested scopes

    @toji
    toji committed Aug 31, 2022
    Copy the full SHA
    30b5d1b View commit details
    Browse the repository at this point in the history

  5. Added internal error reason and reorganized section

    @toji
    toji committed Aug 31, 2022
    Copy the full SHA
    3d2896f View commit details
    Browse the repository at this point in the history

  6. Addressing more feedback

    @toji
    toji committed Aug 31, 2022
    Copy the full SHA
    a42a684 View commit details
    Browse the repository at this point in the history

  7. Update spec/index.bs 

    Co-authored-by: Kai Ninomiya <kainino@chromium.org>
    @toji @kainino0x
    toji and kainino0x committed Aug 31, 2022
    Copy the full SHA
    4557923 View commit details
    Browse the repository at this point in the history

  8. Update spec/index.bs

    @kainino0x @toji
    kainino0x authored and toji committed Aug 31, 2022
    Copy the full SHA
    4c93612 View commit details
    Browse the repository at this point in the history

  9. Split into two different error types again

    @toji
    toji committed Aug 31, 2022
    Copy the full SHA
    94bf9a4 View commit details
    Browse the repository at this point in the history