Add a data-flow analysis for local variables in uniformity #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-baker
added
wgsl
|
Previews, as seen when this build job started (262b841): |
dneto0
requested changes
Aug 11, 2022
Fixes gpuweb#2859 * Adds local variable value analysis to uniformity to track values * full assignments complete replace a value * partial assignments get connected to previous value * Describes function address space pointers as being desugared into variables and extra value return nodes
* Remove fallthrough references * Clarify what is uniform for pointer parameters (the value pointed to) * Fix edges for switch statement result * Fix typos
alan-baker
force-pushed
the
local-var-uniformity
branch
from
fd5b1bb
to
c78621e
Compare
dneto0
requested changes
Aug 12, 2022
dneto0
approved these changes
Aug 12, 2022
|
Will land this, as this implements the thing already agreed to and implemented in Tint. (hence is implementable). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2859
variables and extra value return nodes