Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ASTC requirement in compatibility mode. #4566

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SenorBlanco
Copy link
Contributor

OpenGL ES 3.1 does not require support for ASTC texture formats.

See #4266 (comment)

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Previews, as seen when this build job started (a0d8117):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

@kainino0x
Copy link
Contributor

This was discussed but doesn't seem like we wrote down a resolution:
https://github.com/gpuweb/gpuweb/wiki/GPU-Web-2024-01-24#astc-textures-arent-required-until-es-32-cant-require-them-in-compat-todo

Guess we should raise it tomorrow (I'm certain it will be quick).

@teoxoy
Copy link
Member

teoxoy commented Apr 10, 2024

Do we have to drop this requirement?

Looking at https://opengles.gpuinfo.org/listreports.php?extension=GL_KHR_texture_compression_astc_ldr&option=not and filtering for OpenGL ES 3.1 I could find the following noteworthy chips:

  • Mali-T604 on android 51
  • Mali-T830 on android 72
  • PowerVR Rogue G6200 on android 5-71
  • PowerVR Rogue G6430 on android 5-71
  • A few Adreno devices on android 4-7 and one on 92

Footnotes

  1. already dropped in https://github.com/gpuweb/gpuweb/issues/4417 2 3

  2. there are a lot more reports that support the extension 2

@SenorBlanco
Copy link
Contributor Author

Thanks for doing the legwork, Teo! I think we discussed this issue before in the group, but we couldn't find a consensus in the notes. Agreed that Android looks ok for ASTC support. I'll hold off on merging this for now. We're going to do some investigation on the ChromeOS side, and if support looks good there as well, I'll drop this issue.

@kainino0x kainino0x marked this pull request as draft April 11, 2024 21:47
@kainino0x kainino0x added the compat WebGPU Compatibility Mode label Apr 16, 2024
@Kangz
Copy link
Contributor

Kangz commented May 7, 2024

GPU Web CG 2024-04-10 Atlantic-time
  • SW: ASTC isn't core until GLES 3.2. Propose we validate this out. In Compat, required only to have BC or ETC2.
  • CW: Teo says on Android, essentially all devices support ASTC in GL. Other devices we care about for Compat that don't support BC?
  • KG: it's unfortunate to have ETC2 as the only available option.
  • KR: Android graphics dashboards still have a lot of GLES 3.1 devices. Do they have the ASTC extension?
  • KN: yes, Teo looked at widespread extension support of the ASTC extension.
  • CW: Need to look at the data on ChromeOS but at least for Android we don't need to remove ASTC.
  • CW: Action: check with ChromeOS folks. If there's widespread ASTC support, we'll close this issue.

@kainino0x kainino0x added the api WebGPU API label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api WebGPU API compat WebGPU Compatibility Mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants