Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest @octokit/rest #1

Closed
wants to merge 1 commit into from

Conversation

gr2m
Copy link
Owner

@gr2m gr2m commented Feb 3, 2020

Related to danger/danger-js#983. Depends on https://github.com/octokit/rest.js/pull/1586.

You had the @octokit/rest version pinned before. I do not think that is necessary, but let me know if you prefer that

@orta
Copy link

orta commented Feb 3, 2020

This PR goes to your repo! - will pull it in manually

@orta
Copy link

orta commented Feb 3, 2020

Merged manually, should I wait for:

index.ts:1:10 - error TS2305: Module '"/Users/ortatherox/dev/danger/memfs-or-file-map-to-github-branch/node_modules/@octokit/rest/index"' has no exported member 'Octokit'.

1 import { Octokit } from "@octokit/rest"
           ~~~~~~~

Or will this work at runtime anyway?

@gr2m
Copy link
Owner Author

gr2m commented Feb 3, 2020

It will work at runtime anyway.

I've merged https://github.com/octokit/rest.js/pull/1586, the release resulting from the change will make TypeScript happy, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants