-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new write-args-file goal #408
Conversation
This PR introduces a goal that only writes the args file, so that other plugins further in the lifecycle can use it. In particular, the Micronaut Maven Plugin needs this goal. The path to the args file is stored in the `MavenProject` properties, an approach that is used by other plugins such as the JaCoCo Maven Plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: this only works for the "main" arguments. Do you need something similar for test
? Also, will this approach work with Micronaut AOT?
The use case is persisting the arguments that
It does work! 🎉 |
* Fix integration with the GraalVM Metadata Repository Blocked by graalvm/native-build-tools#408 * Fix build * Skipping invoker tests * Address Sonar issues, and improve the Dockerfile mojo * Yet another Sonar issue
This PR introduces a goal that only writes the args file, so that other plugins further in the lifecycle can use it. In particular, the Micronaut Maven Plugin needs this goal.
The path to the args file is stored in the
MavenProject
properties, an approach that is used by other plugins such as the JaCoCo Maven Plugin.