Added Debugger.pause() and Debugger.isExecuting() methods. #153
Conversation
| @@ -87,9 +90,11 @@ public Debugger getDebugger() { | |||
| * </ul> | |||
| * | |||
| * @since 0.9 | |||
| * @deprecated Continue is by default, this method is not necessary. | |||
| */ | |||
There was a problem hiding this comment.
I don't think it is necessary to deprecate this method. I know continue is the default action, but having the method allows people to "change their mind". It keeps some symmetry and also advertises that debugger can "continue".
I suggest to integrate the change without this deprecation.
There was a problem hiding this comment.
Well, you have just a single event handler callback to "change your mind", thus I considered this method unnecessary.
But O.K. if you'd like to keep it, I'll change the code accordingly.
entlicher
force-pushed
the
DebuggerPause
branch
3 times, most recently
from
350d4ba
to
957abaf
Compare
…vent is disposable.
entlicher
force-pushed
the
DebuggerPause
branch
from
957abaf
to
a7cdfd4
Compare
|
I've updated the pull request and addressed @jtulach comments. |
|
I am OK with this change from an API and test perspective. |
|
|
|
…tely-test to master * commit 'af32b3ff953bbe8b176bf37385fe62ec8e883371': Make SLTestSuite more flexible
|
Debugger.pause() is there already, but is replaced with DebuggerSession.suspendNextExecution(). |
ExecutionEventis made disposable. When outside of event handler process, all it's methods should throwIllegalStateException, according to javadoc. Also, I've deprecatedprepareContinue()method, since continue is by default.To add a "pause" functionality (which could be achieved by calling
ExecutionEvent.prepareStepInto()any time during language execution, but this is not possible any more),Debugger.pause()method is introduced. Also,Debugger.isExecuting()is added so that we can test whether we can expect thatpause()will actually pause anything.Test is included.