New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Message.WRITE final #38
Conversation
@eregon yes, the |
OK, will do. |
Done. |
Changing WRITE field to final is correct, but incompatible change. I'd like to do it, but please get wider approval. Write to mailing list and to known language maintainers to confirm they are OK with the change. (Assuming they are) merge then. |
I approve of the change. It's an API error and very unlikely somebody depends on it (nobody should ever write to the (WRITE) field), so it should be fixed. |
I'll merge this tomorrow. |
ready for merging, but needs to be rebased onto master; @eregon |
Rebased. |
…/truffle:DebuggerPause to master Debugger.pause * commit '09d076ce607b4e704bf6991df03ee52ab5cbc546': Added Debugger.pause() method. ExecutionEvent is disposable.
Adds README-Mandrel.md
All
Message
statics arefinal
exceptWRITE
.INSTANCE
fields are also not final, but accessed only here, should we make themfinal
as well?