Skip to content

Commit

Permalink
refactor: apply PR requested changes
Browse files Browse the repository at this point in the history
  • Loading branch information
pyphilia committed Nov 18, 2020
1 parent 6d1cbc3 commit 85c70bd
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 9 deletions.
2 changes: 0 additions & 2 deletions scripts/setup.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ const env = JSON.stringify({
GOOGLE_API_KEY,
GOOGLE_ANALYTICS_ID,
LOGGING_LEVEL,
HELLO: 'er',
REACT_APP_HELLO_D: 'wef',
});

fs.writeFileSync(path.join(DEFAULT_PATH, NAME), env, { encoding: 'utf8' });
3 changes: 2 additions & 1 deletion src/components/common/WelcomeContent.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
} from '../../config/paths';
import { VISIT_SPACE_BUTTON_CLASS } from '../../config/selectors';

const styles = theme => ({
const styles = (theme) => ({
...Styles(theme),
wrapper: {
display: 'flex',
Expand Down Expand Up @@ -102,6 +102,7 @@ class WelcomeContent extends Component {
{t('Welcome to Graasp Desktop')}
</Typography>
<ButtonGroup
disableElevation
variant="contained"
color="primary"
aria-label="contained group primary button"
Expand Down
2 changes: 1 addition & 1 deletion src/components/dashboard/ActionBarChart.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class ActionBarChart extends PureComponent {
theme: PropTypes.shape({
palette: PropTypes.shape({
type: PropTypes.string.isRequired,
primary: PropTypes.shape().isRequired,
primary: PropTypes.shape({}).isRequired,
}).isRequired,
}).isRequired,
i18n: PropTypes.shape({
Expand Down
2 changes: 1 addition & 1 deletion src/components/dashboard/ActionLineChart.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class ActionLineChart extends PureComponent {
theme: PropTypes.shape({
palette: PropTypes.shape({
type: PropTypes.string.isRequired,
primary: PropTypes.shape().isRequired,
primary: PropTypes.shape({}).isRequired,
}).isRequired,
}).isRequired,
i18n: PropTypes.shape({
Expand Down
8 changes: 4 additions & 4 deletions src/components/signin/SignInScreen.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ const CssTextField = withStyles({
},
})(TextField);

const styles = theme => ({
const styles = (theme) => ({
...Styles(theme),
graaspLogo: { padding: '0px 45px', width: '95%' },
graaspLogo: { padding: theme.spacing(2), width: '95%' },
});

class SignInScreen extends Component {
Expand Down Expand Up @@ -151,13 +151,13 @@ class SignInScreen extends Component {
dispatchSignIn({ anonymous: true, lang });
};

handleUsername = event => {
handleUsername = (event) => {
const username = event.target ? event.target.value : event;
const usernameIsEmpty = !username.length;
this.setState({ username, usernameIsEmpty });
};

handleKeyPressed = event => {
handleKeyPressed = (event) => {
if (event.key === 'Enter') {
this.handleSignIn();
}
Expand Down

0 comments on commit 85c70bd

Please sign in to comment.