Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add timestamp to app url #904

Merged
merged 2 commits into from
Jun 17, 2024
Merged

fix: add timestamp to app url #904

merged 2 commits into from
Jun 17, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Jun 17, 2024 •
edited
Loading

fix #903

@spaenleh spaenleh requested review from pyphilia and ReidyT June 17, 2024 07:07
@spaenleh spaenleh self-assigned this Jun 17, 2024
@spaenleh spaenleh added the bug 🪲 Something isn't working label Jun 17, 2024
ReidyT
ReidyT approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😶‍🌫️ I just let a comment about the name of the new param.

src/items/AppItem.tsx Outdated Show resolved Hide resolved
@spaenleh spaenleh enabled auto-merge June 17, 2024 12:59
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 17, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 85a8974 Jun 17, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Merged
@spaenleh spaenleh deleted the 903-fix-app-index-caching branch June 26, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees

@spaenleh spaenleh

Labels
bug 🪲 Something isn't working v4.20.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

index.html can be aggresively cached by the browser causing issues
2 participants
@spaenleh @ReidyT