fix: use batching for removing products and product models

graciousagency · Apr 12, 2023 · 11837e7 · 11837e7
1 parent eecc22b
commit 11837e7
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 11 deletions.
diff --git a/src/Command/PimMassDeleteProductModelsCommand.php b/src/Command/PimMassDeleteProductModelsCommand.php
@@ -48,12 +48,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         }
 
         try {
-            $productModels = $this->repository->findAll();
-
-            foreach ($productModels as $productModel) {
-                $this->removeProductModel($io, $productModel);
-            }
-
+            $this->removeProductModels($io);
             $this->productAndProductModelClient->refreshIndex();
         } catch (ElasticsearchException $e) {
             $io->error($e->getMessage());
@@ -87,4 +82,17 @@ private function removeProductModel(SymfonyStyle $io, ProductModelInterface $pro
 
         ($this->removeProductModelHandler)($command);
     }
+
+    private function removeProductModels(SymfonyStyle $io): void
+    {
+        do {
+            $productModels = $this->repository->findBy([], ['id' => 'ASC'], 100);
+            if (count($productModels) === 0) {
+                break;
+            }
+            foreach ($productModels as $productModel) {
+                $this->removeProductModel($io, $productModel);
+            }
+        } while(count($productModels) > 0);
+    }
 }
diff --git a/src/Command/PimMassDeleteProductsCommand.php b/src/Command/PimMassDeleteProductsCommand.php
@@ -44,11 +44,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         }
 
         try {
-            $products = $this->repository->findAll();
-
-            foreach ($products as $product) {
-                $this->remover->remove($product);
-            }
+            $this->removeProducts();
             $this->productAndProductModelClient->refreshIndex();
         } catch (ElasticsearchException $e) {
             $io->error($e->getMessage());
@@ -61,4 +57,17 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $io->success('All done!');
         return Command::SUCCESS;
     }
+
+    private function removeProducts(): void
+    {
+        do {
+            $products = $this->repository->findBy([], ['id' => 'ASC'], 100);
+            if (count($products) === 0) {
+                break;
+            }
+            foreach ($products as $product) {
+                $this->remover->remove($product);
+            }
+        } while(count($products) > 0);
+    }
 }