ensure dataframe doesn't scroll unless needed (#5445)

* ensure dataframe doesn't scroll unless needed * add changeset * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
gradio-app · Sep 7, 2023 · 67bb7bc · 67bb7bc
1 parent 710cbb6
commit 67bb7bc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.changeset/chatty-socks-bow.md b/.changeset/chatty-socks-bow.md
@@ -0,0 +1,6 @@
+---
+"@gradio/dataframe": patch
+"gradio": patch
+---
+
+fix:ensure dataframe doesn't scroll unless needed
diff --git a/js/dataframe/shared/VirtualTable.svelte b/js/dataframe/shared/VirtualTable.svelte
@@ -103,11 +103,14 @@
 			return "forwards";
 		}
 
+		const { top: viewport_top } = viewport.getBoundingClientRect();
 		const { top, bottom } = current.getBoundingClientRect();
-		if (top < 37) {
+
+		if (top - viewport_top < 37) {
 			return "back";
 		}
-		if (bottom > viewport_height) {
+
+		if (bottom - viewport_top > viewport_height) {
 			return "forwards";
 		}