Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure dataframe doesn't scroll unless needed #5445

Merged
merged 3 commits into from Sep 7, 2023
Merged

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented Sep 7, 2023

Description

There was some faulty logic when determining if a cell is on or off screen. Clicking a cell would sometimes scroll so that cell appeared at the bottom of the dataframe. This PR fixes it.

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Sep 7, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/c65ac3e1c1a7efb8856042f57b09eec04e88dcb7/gradio-3.43.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@c65ac3e1c1a7efb8856042f57b09eec04e88dcb7#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Sep 7, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/dataframe patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

ensure dataframe doesn't scroll unless needed

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@pngwn pngwn added v: patch A change that requires a patch release t: fix A change that implements a fix labels Sep 7, 2023
@freddyaboulton
Copy link
Collaborator

Confirmed the fix locally thanks @pngwn !

@freddyaboulton freddyaboulton merged commit 67bb7bc into main Sep 7, 2023
12 of 13 checks passed
@freddyaboulton freddyaboulton deleted the df-click-bug branch September 7, 2023 21:27
@pngwn pngwn mentioned this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: fix A change that implements a fix v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants