Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding untracked files from demo notebook check action #2897

Merged
merged 3 commits into from
Dec 28, 2022

Conversation

aliabd
Copy link
Collaborator

@aliabd aliabd commented Dec 28, 2022

Checks to see if file is tracked by git before adding a wget for it in the notebook. This issue was getting annoying in a lot of PRs.

Closes: #2756

@aliabd aliabd requested review from abidlabs and freddyaboulton and removed request for abidlabs December 28, 2022 00:34
@github-actions
Copy link
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2897-all-demos

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful @aliabd !

@aliabd aliabd requested a review from abidlabs December 28, 2022 01:58
@abidlabs
Copy link
Member

Tested & works for me. Thanks @aliabd!

@aliabd aliabd merged commit d934828 into main Dec 28, 2022
@aliabd aliabd deleted the aliabd/notebook-git branch December 28, 2022 12:40
dawoodkhan82 pushed a commit that referenced this pull request Dec 29, 2022
* excluding untracked files from wget

* changelog
dawoodkhan82 added a commit that referenced this pull request Jan 5, 2023
* multiselect dropdown

* fixes

* more fixes

* changes

* changelog

* formatting

* format notebooks

* type fixes

* notebok fix

* remove console log

* notebook fix

* type fix

* Revert "format notebooks"

This reverts commit fb8762e.

* notebook fix

* bug fixes

* Update CHANGELOG.md

* Excluding untracked files from demo notebook check action (#2897)

* excluding untracked files from wget

* changelog

* fix setting default values

* typeability and arrow key support

* python types

* reformat

* another type check

* minor fixes + interactive false fix

* change remove token styling

* separate multiselect into separate file

* style fixes

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* some more style fixes

* small bug fix

* addressed pr comments

* fix active color highlighting

Co-authored-by: Ali Abdalla <ali.si3luwa@gmail.com>
Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude untracked files in notebook generation script
3 participants