-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not inherit
text-decoration
on <a>
#3352
Conversation
It seems reasonable that by default links should be decorated (underlined), and that undecorated links are the special case, not the other way around.
With `a { text-decoration: inherit; }` removed from the CSS reset, there should be no need to explicitly specify these anymore.
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes: pip install nbformat && cd demo && python generate_notebooks.py |
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3352-all-demos |
I'll try to get to this before the end of the week. I don't have any issue with the code but this could break the UI anywhere we are using an anchor tag for anything, so will need thorough testing. |
As an aside, are we sure #837 is still present? The HTML component gets the |
Tested, you're right @pngwn links show up just fine: import gradio as gr
with gr.Blocks() as demo:
gr.HTML(
"""
Visit <a href="www.google.com">www.google.com</a> and click <button>here</button>
""")
demo.launch() Looks like we can close this PR and the underlying issue (#837). Also tested a related issue (#2520), which I can confirm is still open on the latest version of gradio. |
Awesome. |
Description
It seems reasonable that by default links should be decorated (underlined), and that undecorated links are the special case, not the other way around.
Closes #837 (tentatively
Checklist:
I have commented my code in hard-to-understand areascc. @pngwn & @aliabid94, who originally added this in d6fbc32