-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support gr.Progress() in python client #3924
Conversation
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3924-all-demos |
client/python/test/test_client.py
Outdated
statuses.append(job.status()) | ||
time.sleep(0.05) | ||
assert any(s.code == Status.PROGRESS for s in statuses) | ||
assert any(s.progress_data is not None for s in statuses) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can we make this test more speicific? E.g. assert something like the
any(s.progress_data == ProgressUnit(index=19, length=20, unit="steps", progress=None, desc=None) for s in statuses)
It will help readers of the codebase understand the expected format of the progress data
Nice fix @freddyaboulton! This LGTM. I would just add some more documentation around the And I would add a test for a difference Space which doesn't have a progress bar, asserting that the |
23ab7e2
to
5f61548
Compare
Thanks for the review and helpful comments @abidlabs ! Pushed both of those changes up and will fix after CI |
ae70d16
to
a11af11
Compare
Description
There was a bug where progress updates via gr.Progress were causing the client to crash. This PR adds the correct parsing to the progress messages so that they can be accessed via
job.status().progress_data
Checklist:
A note about the CHANGELOG
Hello 👋 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)
in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)
".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.