Strip username before login and add unit test within test_post_login
#5096
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue of spaces being kept at the beginning and end of the username's Textbox on the login page in gradio. The proposed solution is to modify the login route in the
gradio/routes.py
script to strip the username input before processing it. This will remove any leading or trailing spaces from the username, resolving the issue of spaces causing login problems.Summary of Changes
login
route ingradio/routes.py
to apply thestrip()
method to the username input.username, password = form_data.username, form_data.password
tousername, password = form_data.username.strip(), form_data.password
.test_post_login
to verify the stripping of spaces from the username input.Please review and merge this PR. Thank you!
Fixes #5056.
To checkout this PR branch, run the following command in your terminal:
To get Sweep to edit this pull request, leave a comment below or in the code. Leaving a comment in the code will only modify the file but commenting below can change the entire PR.