Adds kwarg to disable html sanitization in `gr.Chatbot()` #5304

dawoodkhan82 · 2023-08-23T13:34:02Z

Description

Adds kwarg to disable html sanitization in gr.Chatbot()

Closes: #5078

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh
You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

gradio-pr-bot · 2023-08-23T13:34:18Z

🪼 branch checks and previews

•	Name	Status	URL
	Spaces	ready!	Spaces preview
	Website	ready!	Website preview
	Storybook	ready!	Storybook preview
	Visual tests	all good!	Build review
🦄	Changes	detected!	Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/cbbb9784aca375f58fe594d975a8f3dfe4aba697/gradio-3.41.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@cbbb9784aca375f58fe594d975a8f3dfe4aba697#subdirectory=client/python"

gradio-pr-bot · 2023-08-23T13:34:55Z

🦄 change detected

This Pull Request includes changes to the following packages.

Package	Version
`@gradio/chatbot`	`patch`
`@gradio/markdown`	`patch`
`gradio`	`patch`
`website`	`patch`

Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Adds kwarg to disable html sanitization in gr.Chatbot()

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

Maintainers can change the version label to modify the version bump.
If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

dawoodkhan82 · 2023-08-23T13:34:57Z

Will have to update this pr once #5279 is merged in. I can also add this kwarg to markdown and dataframe.

gradio/components/chatbot.py

abidlabs · 2023-08-23T14:22:41Z

gradio/components/chatbot.py

@@ -76,6 +77,7 @@ def __init__(
            show_share_button: If True, will show a share icon in the corner of the component that allows user to share outputs to Hugging Face Spaces Discussions. If False, icon does not appear. If set to None (default behavior), then the icon appears if this Gradio app is launched on Spaces, but not otherwise.
            show_copy_button: If True, will show a copy button for each chatbot message.
            avatar_images: Tuple of two avatar image paths or URLs for user and bot (in that order). Pass None for either the user or bot image to skip. Must be within the working directory of the Gradio app or an external URL.
+            disable_html_sanitization: If True, will disable HTML sanitization for chatbot messages. This is not recommended, as it can lead to security vulnerabilities.


Suggested change

disable_html_sanitization: If True, will disable HTML sanitization for chatbot messages. This is not recommended, as it can lead to security vulnerabilities.

disable_html_sanitization: If True, will disable HTML sanitization for chatbot messages. This is generally not recommended, as it can lead to cross-site scripting security vulnerabilities.

abidlabs · 2023-08-23T14:23:20Z

Will have to update this pr once #5279 is merged in. I can also add this kwarg to markdown and dataframe.

Makes sense. Put a suggestion above as well

freddyaboulton

Agree with @abidlabs renaming suggestion. Otherwise this looks good to me!

* add chmod commands to grant execute permissions to each script before running them * increase the memory limit * Increase memory requirement to 8 * Setting a minimum specification for codespace machines

* add chmod commands to grant execute permissions to each script before running them * increase the memory limit * Increase memory requirement to 8 * Setting a minimum specification for codespace machines * Added label_angle parameter to LinePlot * add the x_label_angle and y_label_angle to the postprocess * Add x_label_angle and y_label_angle to ScatterPlot * Add x_label_angle and y_label_angle to BarPlot * Remove postCreateCommand update from this PR, it is in its own PR * Remove custumization on the devcontainer, it is on another PR * Remove extra line on the devcontainer, it is on another PR * add changeset * update the parameter definition in the docstring --------- Co-authored-by: Abubakar Abid <abubakar@huggingface.co> Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* waveform res fix * add changeset * add changeset * Improve audio streaming (#5238) * changes * changes * add changeset * add changeset * chages * Update silver-clowns-brush.md * changes * chagers * changes * Update silver-clowns-brush.md * change * change --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: pngwn <hello@pngwn.io> * Tweaks to `icon` parameter in `gr.Button()` (#5285) * button * add changeset * fix * add changeset * add changeset * types * type fix * formatting * fix based on review * fix unit tests * stories --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> * test * test --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: aliabid94 <aabid94@gmail.com> Co-authored-by: pngwn <hello@pngwn.io> Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

* changes * changes * add changeset * add changeset * chages * Update silver-clowns-brush.md * changes * chagers * changes * Update silver-clowns-brush.md * change * change * change * changes * chages * changes * add changeset * changes * changes * changes --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: pngwn <hello@pngwn.io>

* changes * changes * remove languages from code docs * fix img path in guide * rework event listeners * add changeset * remove console log * name it event arguments * Update js/_website/src/lib/components/EventListeners.svelte Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * Update js/_website/src/lib/components/EventListeners.svelte Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * requested changes --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

* only start listening for events after the components are mounted * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* removes missing part of bottom border on file component * add changeset * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* test test * fix test * tweak * tweak test name

* add json generation to prepare * add changeset * remove pnpm prepare * add changeset * bring back prepare, add ignore scripts * delete changeset * add to right commadn * add frozen lockfile to gh_action_pypi * remove unused gh_action_pypi script * remove unused scripts --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* ensure dropwdown stays open when new data is passed in * add changeset * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* fix changelog generation * fix changelog generation * fix

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix changelog generation * fix changelog generation * fix * fix script

* fix changelog generation * fix changelog generation * fix * fix script * fix script

* fix changelog generation * fix changelog generation * fix * fix script * fix script * fix vars

* fix changelog generation * fix changelog generation * fix * fix script * fix script * fix vars * fix vars

* Fix bug * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* changes * changes * add changeset * changes * changes * fix box changes on website * add changeset * changes * changes * Revert "changes" This reverts commit 189b4e8. * chanegs * changes * changes * changes * changes * add changeset * Update fancy-bats-deny.md --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: aliabd <ali.si3luwa@gmail.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

* fix: wrap avatar-image in a div to clip its shape and add data url support * add changeset * revert get file from data url * add changeset --------- Co-authored-by: Dawood Khan <dawoodkhan82@gmail.com> Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

disable sanitize

459acf8

add changeset

37084e7

abidlabs reviewed Aug 23, 2023

View reviewed changes

gradio/components/chatbot.py Outdated Show resolved Hide resolved

abidlabs reviewed Aug 23, 2023

View reviewed changes

freddyaboulton reviewed Aug 24, 2023

View reviewed changes

Faiga91 and others added 21 commits August 28, 2023 18:38

Fix devcontainer postCreateCommand (#5289)

683dc71

* add chmod commands to grant execute permissions to each script before running them * increase the memory limit * Increase memory requirement to 8 * Setting a minimum specification for codespace machines

merge

98d7e78

fix (#5308)

0958038

only start listening for events after the components are mounted (#5312)

8972cb9

* only start listening for events after the components are mounted * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

Restores missing part of bottom border on file component (#5313)

7135c41

* removes missing part of bottom border on file component * add changeset * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

chore: update versions (#5177)

8bfda63

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Test Blocks.svelte footer copy (#5307)

064738e

* test test * fix test * tweak * tweak test name

ensure login form has correct styles (#5324)

7cd8b40

fix changelog generation (#5328)

c25f7ab

ensure dropdown stays open when identical data is passed in (#5323)

227201b

* ensure dropwdown stays open when new data is passed in * add changeset * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

Fix ci again again again (#5329)

f8c58cc

* fix changelog generation * fix changelog generation * fix

chore: update versions (#5326)

b03c2fd

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Fix ci again again again (#5330)

64b8e32

* fix changelog generation * fix changelog generation * fix * fix script

Fix ci again again again (#5331)

36db151

* fix changelog generation * fix changelog generation * fix * fix script * fix script

Fix ci again again again (#5332)

b1ff9af

* fix changelog generation * fix changelog generation * fix * fix script * fix script * fix vars

Fix ci again again again (#5333)

b4476b1

* fix changelog generation * fix changelog generation * fix * fix script * fix script * fix vars * fix vars

freddyaboulton and others added 9 commits August 28, 2023 18:38

Fix Checkbox select dispatch (#5340)

1676a53

* Fix bug * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

chore: update versions (#5341)

cfa0c2b

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

merge

4a42a8a

add kwarg to markdown

670c95e

add changeset

8d6f91f

conflicts fix

6371385

config

55868c5

dawoodkhan82 merged commit 0589230 into main Aug 29, 2023
16 checks passed

dawoodkhan82 deleted the sanitize_disable branch August 29, 2023 04:26

pngwn mentioned this pull request Aug 29, 2023

chore: update versions #5361

Merged

This was referenced Aug 29, 2023

Hide avatar when message none #5366

Merged

Chatbot sanitize removes scripting from messages. #5382

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds kwarg to disable html sanitization in `gr.Chatbot()` #5304

Adds kwarg to disable html sanitization in `gr.Chatbot()` #5304

dawoodkhan82 commented Aug 23, 2023

gradio-pr-bot commented Aug 23, 2023 •

edited

gradio-pr-bot commented Aug 23, 2023 •

edited

Something isn't right?

dawoodkhan82 commented Aug 23, 2023

abidlabs Aug 23, 2023 •

edited

abidlabs commented Aug 23, 2023

freddyaboulton left a comment

	disable_html_sanitization: If True, will disable HTML sanitization for chatbot messages. This is not recommended, as it can lead to security vulnerabilities.
	disable_html_sanitization: If True, will disable HTML sanitization for chatbot messages. This is generally not recommended, as it can lead to cross-site scripting security vulnerabilities.

Adds kwarg to disable html sanitization in gr.Chatbot() #5304

Adds kwarg to disable html sanitization in gr.Chatbot() #5304

Conversation

dawoodkhan82 commented Aug 23, 2023

Description

🎯 PRs Should Target Issues

Tests

gradio-pr-bot commented Aug 23, 2023 • edited

🪼 branch checks and previews

gradio-pr-bot commented Aug 23, 2023 • edited

🦄 change detected

This Pull Request includes changes to the following packages.

With the following changelog entry.

Something isn't right?

dawoodkhan82 commented Aug 23, 2023

abidlabs Aug 23, 2023 • edited

Choose a reason for hiding this comment

abidlabs commented Aug 23, 2023

freddyaboulton left a comment

Choose a reason for hiding this comment

Adds kwarg to disable html sanitization in `gr.Chatbot()` #5304

Adds kwarg to disable html sanitization in `gr.Chatbot()` #5304

gradio-pr-bot commented Aug 23, 2023 •

edited

gradio-pr-bot commented Aug 23, 2023 •

edited

abidlabs Aug 23, 2023 •

edited