Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Checkbox select dispatch #5340

Merged
merged 2 commits into from Aug 25, 2023
Merged

Fix Checkbox select dispatch #5340

merged 2 commits into from Aug 25, 2023

Conversation

freddyaboulton
Copy link
Collaborator

Description

Closes #5327

The event data was not being passed up.

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Aug 25, 2023 •
edited

🪼 branch checks and previews

• Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/d83efb84603d6d2ffa034257282e4c77d250dfb3/gradio-3.41.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@d83efb84603d6d2ffa034257282e4c77d250dfb3#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/checkbox patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix Checkbox select dispatch

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?
  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton freddyaboulton marked this pull request as ready for review August 25, 2023 15:33
@abidlabs
Copy link
Member

Thanks @freddyaboulton! Change looks good & confirms it fixes:

import gradio as gr 


def on_option_changed(evt: gr.SelectData):
    print(evt.selected)

with gr.Blocks() as demo:
    chx = gr.Checkbox()
    text = gr.Textbox()
    chx.select(on_option_changed, None, text)

demo.launch()

@freddyaboulton
Copy link
Collaborator Author

Thanks @abidlabs !

@freddyaboulton freddyaboulton merged commit df090e8 into main Aug 25, 2023
13 checks passed
@freddyaboulton freddyaboulton deleted the 5327-checkbox-select-patch branch August 25, 2023 15:42
@pngwn pngwn mentioned this pull request Aug 25, 2023
Merged
@pngwn
Copy link
Member

pngwn commented Aug 25, 2023

Copilot did me wrong.

dawoodkhan82 pushed a commit that referenced this pull request Aug 28, 2023
@freddyaboulton @gradio-pr-bot @dawoodkhan82
Fix Checkbox select dispatch (#5340)
1676a53 
* Fix bug

* add changeset

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
dawoodkhan82 added a commit that referenced this pull request Aug 29, 2023
@dawoodkhan82 @gradio-pr-bot
@Faiga91 @abidlabs @aliabid94 @pngwn @aliabd @github-actions @hannahblair @freddyaboulton @Keldos-Li
Adds kwarg to disable html sanitization in gr.Chatbot() (#5304)
0589230 
* disable sanitize

* add changeset

* Fix devcontainer postCreateCommand (#5289)

* add chmod commands to grant execute permissions to each script before running them

* increase the memory limit

* Increase memory requirement to 8

* Setting a minimum specification for codespace machines

* Rotate axes labels on LinePlot, BarPlot, and ScatterPlot (#5305)

* add chmod commands to grant execute permissions to each script before running them

* increase the memory limit

* Increase memory requirement to 8

* Setting a minimum specification for codespace machines

* Added label_angle parameter to LinePlot

* add the x_label_angle and y_label_angle to the postprocess

* Add x_label_angle and y_label_angle to ScatterPlot

* Add x_label_angle and y_label_angle to BarPlot

* Remove postCreateCommand update from this PR, it is in its own PR

* Remove custumization on the devcontainer, it is on another PR

* Remove extra line  on the devcontainer, it is on another PR

* add changeset

* update the parameter definition in the docstring

---------

Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* `make_waveform()` twitter video resolution fix (#5296)

* waveform res fix

* add changeset

* add changeset

* Improve audio streaming (#5238)

* changes

* changes

* add changeset

* add changeset

* chages

* Update silver-clowns-brush.md

* changes

* chagers

* changes

* Update silver-clowns-brush.md

* change

* change

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Co-authored-by: pngwn <hello@pngwn.io>

* Tweaks to `icon` parameter in `gr.Button()` (#5285)

* button

* add changeset

* fix

* add changeset

* add changeset

* types

* type fix

* formatting

* fix based on review

* fix unit tests

* stories

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* test

* test

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Co-authored-by: aliabid94 <aabid94@gmail.com>
Co-authored-by: pngwn <hello@pngwn.io>
Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

* Allow caching examples with streamed output (#5295)

* changes

* changes

* add changeset

* add changeset

* chages

* Update silver-clowns-brush.md

* changes

* chagers

* changes

* Update silver-clowns-brush.md

* change

* change

* change

* changes

* chages

* changes

* add changeset

* changes

* changes

* changes

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Co-authored-by: pngwn <hello@pngwn.io>

* Create event listener table for components on docs (#5298)

* changes

* changes

* remove languages from code docs

* fix img path in guide

* rework event listeners

* add changeset

* remove console log

* name it event arguments

* Update js/_website/src/lib/components/EventListeners.svelte

Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

* Update js/_website/src/lib/components/EventListeners.svelte

Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

* requested changes

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

* merge

* fix (#5308)

* only start listening for events after the components are mounted (#5312)

* only start listening for events after the components are mounted

* add changeset

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* Restores missing part of bottom border on file component (#5313)

* removes missing part of bottom border on file component

* add changeset

* add changeset

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* chore: update versions (#5177)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Test Blocks.svelte footer copy (#5307)

* test test

* fix test

* tweak

* tweak test name

* ensure login form has correct styles (#5324)

* fix changelog generation (#5328)

* Add ignore scripts to pnpm i in pypi action (#5316)

* add json generation to prepare

* add changeset

* remove pnpm prepare

* add changeset

* bring back prepare, add ignore scripts

* delete changeset

* add to right commadn

* add frozen lockfile to gh_action_pypi

* remove unused gh_action_pypi script

* remove unused scripts

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* ensure dropdown stays open when identical data is passed in (#5323)

* ensure dropwdown stays open when new data is passed in

* add changeset

* add changeset

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* Fix ci again again again (#5329)

* fix changelog generation

* fix changelog generation

* fix

* chore: update versions (#5326)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix ci again again again (#5330)

* fix changelog generation

* fix changelog generation

* fix

* fix script

* Fix ci again again again (#5331)

* fix changelog generation

* fix changelog generation

* fix

* fix script

* fix script

* Fix ci again again again (#5332)

* fix changelog generation

* fix changelog generation

* fix

* fix script

* fix script

* fix vars

* Fix ci again again again (#5333)

* fix changelog generation

* fix changelog generation

* fix

* fix script

* fix script

* fix vars

* fix vars

* Fix Checkbox select dispatch (#5340)

* Fix bug

* add changeset

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* Minor bug fix sweep (#5284)

* changes

* changes

* add changeset

* changes

* changes

* fix box changes on website

* add changeset

* changes

* changes

* Revert "changes"

This reverts commit 189b4e8.

* chanegs

* changes

* changes

* changes

* changes

* add changeset

* Update fancy-bats-deny.md

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Co-authored-by: aliabd <ali.si3luwa@gmail.com>
Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

* Fix: wrap avatar-image in a div to clip its shape (#5319)

* fix: wrap avatar-image in a div to clip its shape

and add data url support

* add changeset

* revert get file from data url

* add changeset

---------

Co-authored-by: Dawood Khan <dawoodkhan82@gmail.com>
Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* chore: update versions (#5341)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* add kwarg to markdown

* add changeset

* config

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Co-authored-by: Faiga Alawad <faiga.alawd91@gmail.com>
Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
Co-authored-by: aliabid94 <aabid94@gmail.com>
Co-authored-by: pngwn <hello@pngwn.io>
Co-authored-by: Ali Abdalla <ali.si3luwa@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Hannah <hannahblair@users.noreply.github.com>
Co-authored-by: Freddy Boulton <alfonsoboulton@gmail.com>
Co-authored-by: Keldos <Keldos.ljw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abidlabs abidlabs abidlabs approved these changes

@pngwn pngwn Awaiting requested review from pngwn

@aliabid94 aliabid94 Awaiting requested review from aliabid94

@dawoodkhan82 dawoodkhan82 Awaiting requested review from dawoodkhan82

@hannahblair hannahblair Awaiting requested review from hannahblair

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkbox select handler crashes
4 participants
@freddyaboulton @gradio-pr-bot @abidlabs @pngwn