Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change BlockLabel element to use <label> #5864

Merged
merged 11 commits into from Oct 12, 2023
Merged

Change BlockLabel element to use <label> #5864

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cc1b666
refactor: change to label tag where label property is accepted by com…
aileenvl Oct 11, 2023
e08e271
add changeset
gradio-pr-bot Oct 11, 2023
a105a9a
fix: A form label must be associated with a control.
aileenvl Oct 11, 2023
760130d
Merge branch 'avl/issue-5454-label-html' of https://github.com/aileen…
aileenvl Oct 11, 2023
a86c285
Merge branch 'main' into avl/issue-5454-label-html
hannahblair Oct 11, 2023
3683e7b
Update js/atoms/src/BlockLabel.svelte
aileenvl Oct 11, 2023
fc1f7c0
add changeset
gradio-pr-bot Oct 12, 2023
8939cea
add changeset
gradio-pr-bot Oct 12, 2023
14e81d7
Merge branch 'main' into avl/issue-5454-label-html
hannahblair Oct 12, 2023
6b4d92c
fix: refactor use label tag instead of div tag
aileenvl Oct 12, 2023
470903f
fix: A form label must be associated with a control
aileenvl Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/salty-donuts-hear.md
View file
Open in desktop
@@ -0,0 +1,6 @@
---
"@gradio/atoms": minor
"gradio": minor
---

feat:Change `BlockLabel` element to use `<label>`
17 changes: 17 additions & 0 deletions js/atoms/src/BlockLabel.svelte
View file
Open in desktop
Expand Up @@ -17,7 +17,24 @@
<Icon />
</span>


<label
class:hide={!show_label}
class:sr-only={!show_label}
class:float
class:hide-label={disable}
data-testid="block-label"
>
<span>
<Icon />
</span>
{label}
</label>

<style>
label {
display: inline-flex;
aileenvl marked this conversation as resolved.
Show resolved Hide resolved

</div>

<style>
Expand Down