Fixes Drag and Drop for Upload #6525

dawoodkhan82 · 2023-11-21T16:23:32Z

Description

Fixes the issue around the mime-type checks in the Upload component, which was causing errors for drag and dropping files.

Closes: #6490

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh
You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

gradio-pr-bot · 2023-11-21T16:23:46Z

🪼 branch checks and previews

•	Name	Status	URL
	Spaces	ready!	Spaces preview
	Website	ready!	Website preview
	Storybook	ready!	Storybook preview
	Visual tests	all good!	Build review
🦄	Changes	detected!	Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/f135675966e52c7066411dcede2b1ede1f05f768/gradio-4.9.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@f135675966e52c7066411dcede2b1ede1f05f768#subdirectory=client/python"

gradio-pr-bot · 2023-11-21T16:24:22Z

🦄 change detected

This Pull Request includes changes to the following packages.

Package	Version
`@gradio/model3d`	`patch`
`@gradio/upload`	`patch`
`gradio`	`patch`

Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fixes Drag and Drop for Upload

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

Maintainers can change the version label to modify the version bump.
If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

freddyaboulton

Can you modify the model3d_component_events.spec.ts and maybe write some 2e2 tests for gr.File? We have some for UploadButton but not File. There's an example of DnD in video_component_events.spec.ts.

* clog version * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* Fix version in other changelog why do we have 2? * remove changeset

* fix text alignment when rtl is true * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* amend like/dislike logic * add like/dislike to chatbot demo and add e2e test * add changeset * e2e test changes * revert chatbot_component changes * tweak * generate notebooks * tweak --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* feat: make UploadButton accept icon * add changeset * add proxy url prop * add stories --------- Co-authored-by: Abubakar Abid <abubakar@huggingface.co> Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

…changes to root, glob, or glob_dir (#6550) * Add code * add changeset * add changeset * Add test * fix --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

…6565) * Fix uploaded file wasn't moved to custom temp dir at different disks * add changeset * Update routes.py --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Freddy Boulton <alfonsoboulton@gmail.com>

* Fix the docstring of the `Slider` class * add changeset * Update the JSON file generator to output a new field .styled_description to render the inline code syntax in the description field * add changeset * Update style_types() to deal with backticks and single asterisks * Update the inline style converter to use regex for the curly bracket syntax as well * Revert `style_types()` not to touch the `description` field and update the frontend code to apply styling to such formatted texts on Svelte's side * Apply the inline styler to other `.description` field appearances * Apply the inline styler to `.preprocessing`, `.postprocessing`, `.examples-format`, `.events`, and `*.parameters.doc` * Stop applying HTML styles to the JSON data, instaed apply HTML escaping * Escape HTML tokens in .parameters[]["doc"] too * fixes --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Ali Abdalla <ali.si3luwa@gmail.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

* Update zh-CN.json * add changeset * format --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

* client with private space * add changeset * lint * add test --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

…unt=single mode (return None rather) (#6607) * Update file_explorer.py Fixing error if nothing selected in file_count=single mode (return None rather) * add changeset * added unit tests --------- Co-authored-by: Abubakar Abid <abubakar@huggingface.co> Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* remove 2 slider demos * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* fix: configure default encoding as utf-8 * apply doc change for the fix * apply cn doc change for the fix * add changeset * Lint --------- Co-authored-by: Freddy Boulton <alfonsoboulton@gmail.com> Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* fixes * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* amend trimming logic and return original file when error occurs * add interactive story test * add changeset * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

* add show_recording_waveform * add changeset * add animation * Refactor audio component and waveform options * formatting * add margin before audio controls * amend default values * expose gr.WaveformOptions * Tweak waveform options types and handle none * add waveform_options to reverse_audio * tweak bool typing * notebook --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…cy_limit (#6653) * concurrency limit chat interface * add changeset * Update gradio/chat_interface.py Co-authored-by: Abubakar Abid <abubakar@huggingface.co> --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

dawoodkhan82 · 2023-12-11T21:54:17Z

Hmm, so the failing functional tests, are actually passing for me locally. Also by re-running these tests I notice some of them are pretty flaky. Specifically any test using the upload endpoint. await page.waitForResponse("**/upload?*");

…he container styles (#6726) * Remove the styles from the Image/Video primitive components and Fix the container styles * add changeset * Fix image example size styles * Remove border from image/Example with type=gallery --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

dawoodkhan82 · 2023-12-13T15:30:23Z

Tests are passing now! Ready for re-review @abidlabs @freddyaboulton

abidlabs · 2023-12-13T19:53:03Z

Nice @dawoodkhan82! The issue is fixed for me for the gr.File component, but not for the gr.Model3D component. Here's the code I'm trying, and I'm attaching the file (its a .obj file but I've zipped it to be able to upload to GH) as well. Are you able to repro?

import gradio as gr

def noop(*args):
    return None

demo = gr.Interface(
    fn=noop,
    inputs=[gr.File(), gr.Model3D(), gr.Image()],
    outputs=None,
)

demo.launch()

Bunny.obj.zip

abidlabs · 2023-12-13T20:37:58Z

@dawoodkhan82 and I looked into the issue above, it seems like it only affects .obj files

dawoodkhan82 · 2023-12-13T21:41:57Z

@abidlabs Fixed, without (hopefully) breaking anything else!

abidlabs · 2023-12-13T22:41:14Z

Awesome @dawoodkhan82 works for me! Thanks for finding the solution.

abidlabs · 2023-12-13T22:48:33Z

I'll go ahead and merge this in so that we can do a patch release with #6693 and this

fix

8c1138c

add changeset

a431933

freddyaboulton reviewed Nov 21, 2023

View reviewed changes

dawoodkhan82 and others added 25 commits November 23, 2023 01:49

Merge branch 'main' into upload

1706423

tests

454e738

Update package.json

9cd6c80

Hotfix: version on changelog (#6559)

a09b7f5

* clog version * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

Fix version in other changelog (#6561)

6d24072

* Fix version in other changelog why do we have 2? * remove changeset

Ensure Chatbot messages are properly aligned when rtl is true (#6574)

a2b4012

* fix text alignment when rtl is true * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

Fix typo envrion -> environ (#6585)

955b014

Feat: make UploadButton accept icon (#6584)

cf28106

* feat: make UploadButton accept icon * add changeset * add proxy url prop * add stories --------- Co-authored-by: Abubakar Abid <abubakar@huggingface.co> Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

Make FileExplorer work on python 3.8 and 3.9. Also make it update on …

97bd9a7

…changes to root, glob, or glob_dir (#6550) * Add code * add changeset * add changeset * Add test * fix --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

chore(deps): update all non-major dependencies (#6593)

e3c4b6e

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update dependency jsdom to v23 (#6582)

1a84fb8

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

Update zh-CN.json (#6512)

7d6ae2c

* Update zh-CN.json * add changeset * format --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

Fix: Gradio Client work with private Spaces (#6602)

cc4204e

* client with private space * add changeset * lint * add test --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

Remove 2 slider demos from docs (#6624)

5022fb4

* remove 2 slider demos * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

Quick Image + Text Component Fixes (#6635)

4a6b980

* fixes * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

Improve video trimming and error handling (#6566)

ea24897

* amend trimming logic and return original file when error occurs * add interactive story test * add changeset * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>

chore(deps): update dependency chromatic to v10 (#6619)

407aa14

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update chromaui/action action to v10 (#6618)

199ec42

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

dawoodkhan82 added 3 commits December 11, 2023 11:37

Merge branch 'main' into upload

6cecfc5

test

070a3df

Merge branch 'main' into upload

83b15fd

whitphx and others added 12 commits December 12, 2023 10:55

test fix

dfe50c8

add changeset

d51997e

test fix

e718716

Merge branch 'main' into upload

527a1fc

add changeset

3b5157b

test

1eb758b

Merge branch 'main' into upload

ee3fd61

Merge branch 'main' into upload

07df446

test fix

9006872

test fix audio video

219a5e7

format

f0ace11

Merge branch 'main' into upload

8bdc664

fix obj file issue

d0a797f

abidlabs approved these changes Dec 13, 2023

View reviewed changes

abidlabs mentioned this pull request Dec 13, 2023

Python client properly handles hearbeat and log messages. Also handles responses longer than 65k #6693

Merged

abidlabs merged commit 5d51fbc into main Dec 13, 2023
20 checks passed

abidlabs deleted the upload branch December 13, 2023 22:48

pngwn mentioned this pull request Dec 13, 2023

chore: update versions #6779

Merged

ngaudemet mentioned this pull request Jan 11, 2024

Drag and drop doesn't work (neither on Safari or Chrome) #7010

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes Drag and Drop for Upload #6525

Fixes Drag and Drop for Upload #6525

dawoodkhan82 commented Nov 21, 2023

gradio-pr-bot commented Nov 21, 2023 •

edited

gradio-pr-bot commented Nov 21, 2023 •

edited

Something isn't right?

freddyaboulton left a comment

dawoodkhan82 commented Dec 11, 2023 •

edited

dawoodkhan82 commented Dec 13, 2023

abidlabs commented Dec 13, 2023 •

edited

abidlabs commented Dec 13, 2023 •

edited

dawoodkhan82 commented Dec 13, 2023

abidlabs commented Dec 13, 2023

abidlabs commented Dec 13, 2023

Fixes Drag and Drop for Upload #6525

Fixes Drag and Drop for Upload #6525

Conversation

dawoodkhan82 commented Nov 21, 2023

Description

🎯 PRs Should Target Issues

Tests

gradio-pr-bot commented Nov 21, 2023 • edited

🪼 branch checks and previews

gradio-pr-bot commented Nov 21, 2023 • edited

🦄 change detected

This Pull Request includes changes to the following packages.

With the following changelog entry.

Something isn't right?

freddyaboulton left a comment

Choose a reason for hiding this comment

dawoodkhan82 commented Dec 11, 2023 • edited

dawoodkhan82 commented Dec 13, 2023

abidlabs commented Dec 13, 2023 • edited

abidlabs commented Dec 13, 2023 • edited

dawoodkhan82 commented Dec 13, 2023

abidlabs commented Dec 13, 2023

abidlabs commented Dec 13, 2023

gradio-pr-bot commented Nov 21, 2023 •

edited

gradio-pr-bot commented Nov 21, 2023 •

edited

dawoodkhan82 commented Dec 11, 2023 •

edited

abidlabs commented Dec 13, 2023 •

edited

abidlabs commented Dec 13, 2023 •

edited