Remove flag_dir from read_from_flag() #7059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
|
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
|
akx
force-pushed
the
flag-dir
branch
2 times, most recently
from
150d036
to
58596c6
Compare
|
Thank you @akx!! |
Merged
aliabid94
pushed a commit
that referenced
this pull request
Feb 4, 2024
* Remove flag_dir from read_from_flag() * fix * remove unnecessary ruff exception --------- Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The argument isn't used by the function, and it doesn't seem to be used by external code across GitHub either.
This was flagged by Ruff's ARG lint.