Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer importing matplotlib #7157

Merged
merged 1 commit into from Jan 26, 2024
Merged

Defer importing matplotlib #7157

merged 1 commit into from Jan 26, 2024

Conversation

akx
Copy link
Contributor

@akx akx commented Jan 25, 2024

Description

The Gradio features that actually require matplotlib are few and far between, and most matplotlib importing is already deferred.

This moves the rest.

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jan 25, 2024

🪼 branch checks and previews

Name Status URL
🦄 Changes detected! Details

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jan 25, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio minor

With the following changelog entry.

Defer importing matplotlib

⚠️ The changeset file for this pull request has been modified manually, so the changeset generation bot has been disabled. To go back into automatic mode, delete the changeset file.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@akx akx force-pushed the matplotlib-dep branch 2 times, most recently from 4cc443b to ab2dcd0 Compare January 26, 2024 12:28
@akx akx marked this pull request as ready for review January 26, 2024 18:59
@akx
Copy link
Contributor Author

akx commented Jan 26, 2024

I unfortunately can't tell if the test failures are legitimate, or if it's just the test suite being broken since I'm an external contributor and secrets are missing.

@abidlabs
Copy link
Member

We’ll take a look thanks @akx!

@abidlabs
Copy link
Member

LGTM! Thanks again @akx

@abidlabs abidlabs merged commit 46919c5 into gradio-app:main Jan 26, 2024
8 of 13 checks passed
@pngwn pngwn mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants