Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradio/components/dataframe.py not to import pandas.io #7840

Merged
merged 4 commits into from Mar 27, 2024

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Mar 26, 2024

Description

Related to #7791

pandas.io imports matplotlib internally. It takes a long time and makes #7157 less effective.
This PR fixes it.

Performance assessment on Lite

This PR (8194bfd) main (1a7c8d3)
1 7.369 9.023
2 6.909 8.798
3 6.991 9.556
Average 7.090 9.126

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Mar 26, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/8fd4f803fb5726ac99b9e7ea340617519b19653e/gradio-4.23.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@8fd4f803fb5726ac99b9e7ea340617519b19653e#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Mar 26, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix gradio/components/dataframe.py not to import pandas.io

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@whitphx whitphx added the v: patch A change that requires a patch release label Mar 26, 2024
@whitphx whitphx marked this pull request as ready for review March 26, 2024 09:56
@freddyaboulton
Copy link
Collaborator

Nice clean up @whitphx !!

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice speedup! Perhaps we should also lazy import pandas itself?

@whitphx whitphx merged commit ecf5c52 into main Mar 27, 2024
8 checks passed
@whitphx whitphx deleted the not-import-pandas-io branch March 27, 2024 01:39
@whitphx
Copy link
Member Author

whitphx commented Mar 27, 2024

Perhaps we should also lazy import pandas itself?

Yes, I'm going to try it in another PR 👍

@pngwn pngwn mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants