Retain dropdown value if choices have been changed #7401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/ca1eb9f0e9d1d42706e98ead14c71b340c92b473/gradio-4.18.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ca1eb9f0e9d1d42706e98ead14c71b340c92b473#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
abidlabs
changed the title
abidlabs
commented
Feb 12, 2024
| old_choices = choices; | ||
| filtered_indices = handle_filter(choices, input_text); | ||
| if (!allow_custom_value && filtered_indices.length > 0) { |
There was a problem hiding this comment.
A little bit of code duplication from below, but I think its easier to follow this way
abidlabs
requested review from
aliabid94,
aliabd,
dawoodkhan82,
pngwn and
hannahblair
|
Nice! Tested that the fix works 🚀 Can you explain what caused the issue here? |
hannahblair
approved these changes
Feb 12, 2024
|
Thanks @hannahblair for the review! The issue was that we weren't calling |
Merged
This was referenced Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6853 and adds a unit test.