New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure gr.Dropdown
can have an empty initial value
#7431
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/346c255c190ca71ef69475cbca948f2fb8340893/gradio-4.19.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@346c255c190ca71ef69475cbca948f2fb8340893#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
…adio into dropdown-empty-val
gr.Dropdown
can have empty valuegr.Dropdown
can have an empty initial value
Ah interesting. I hadn't realized that the default behavior before 4.19 was to have no option selected in the Dropdown. This is different than how the Change looks good to me @hannahblair, thanks for adding the tests! I also confirmed that #6853 is still fixed with this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hannahblair and @yvrjsharma!
@abidlabs I agree - I initially didn't see an issue with the new behaviour but figured it could be a breaking/frustrating change 😁 |
Description
In PR #7401 we changed the initial value of
value
from[]
toundefined
. This means that theelse
check in the following logic was being run because value is now treated as Falsy:when the
else if (choices.length > 0)
expression passes, we set the selected index to 0, and then set value to 0, resulting in the None value behaviour breaking. So this PR changes the default value back to[]
.Closes: #7429
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh