Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add website to contributing readme #8842

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Add website to contributing readme #8842

merged 5 commits into from
Jul 19, 2024

Conversation

aliabd
Copy link
Collaborator

@aliabd aliabd commented Jul 19, 2024

Long overdue but adds documentation on building the website, and contributing to docs and guides.

@lappemic please feel free to add your thoughts and let me know if you have any suggestions!

Closes: #8782
Closes: #5207

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 19, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/08c0d3108ebe25aadbed2863188af09d418be9cd/gradio-4.38.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@08c0d3108ebe25aadbed2863188af09d418be9cd#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/08c0d3108ebe25aadbed2863188af09d418be9cd/gradio-client-1.3.0.tgz

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 19, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
website minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Add website to contributing readme

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, lgtm @aliabd!


```
pnpm build:cdn-local
pnpm dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to do pnpm i first, right?

Copy link
Contributor

@lappemic lappemic Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me worked pnpm dev.

Edit, thinking a second time i am actually not sure anymore... 🙈

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it hasn't been run before then pnpm i will be required. Can be run from anywhere.

@lappemic
Copy link
Contributor

This is great! LGTM!

Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @aliabd!

@aliabd aliabd enabled auto-merge (squash) July 19, 2024 20:27
@aliabd aliabd merged commit 38c2ad4 into main Jul 19, 2024
8 checks passed
@aliabd aliabd deleted the aliabd/website-readme branch July 19, 2024 21:59
@aliabd aliabd self-assigned this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Build Website Locally and Outdated Contributing Guide Add README for locally building the website
5 participants