Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added interactive parameter to components #992

Merged
merged 18 commits into from
Apr 14, 2022
Merged

Conversation

abidlabs
Copy link
Member

All Component classes now have an interactive parameter, which can be True, False, or (by default), None.

In the Interface class, input components have interactive set to None, but output components set to False

Closes #925

@abidlabs abidlabs requested a review from aliabid94 April 13, 2022 18:36
@pngwn
Copy link
Member

pngwn commented Apr 13, 2022

@abidlabs I have implemented the frontend for this kindof. There are some bugs/ inconsistencies with the static version of components but the mechanism is implemented and can be tested. We can create new issues for any bugs we find.

@pngwn
Copy link
Member

pngwn commented Apr 13, 2022

Hmm test failing, I'll have to take a look at that a little later.

@pngwn
Copy link
Member

pngwn commented Apr 14, 2022

@abidlabs Should be good now. Made some additional tweaks to ensure everything is rendering as expected, even when empty.

We'll need to cleanup the components at some point, the line between what stays in the app and what goes into the separate component is a little blurry atm, but we can sort that out later.

@abidlabs
Copy link
Member Author

abidlabs commented Apr 14, 2022

LGTM everything seems to be working, and the output components for the media types (audio, image, time series, etc.) look very nice!

Feel free to merge whenever you are ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants