-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added interactive parameter to components #992
Conversation
@abidlabs I have implemented the frontend for this kindof. There are some bugs/ inconsistencies with the static version of components but the mechanism is implemented and can be tested. We can create new issues for any bugs we find. |
Hmm test failing, I'll have to take a look at that a little later. |
@abidlabs Should be good now. Made some additional tweaks to ensure everything is rendering as expected, even when empty. We'll need to cleanup the components at some point, the line between what stays in the app and what goes into the separate component is a little blurry atm, but we can sort that out later. |
LGTM everything seems to be working, and the output components for the media types (audio, image, time series, etc.) look very nice! Feel free to merge whenever you are ready. |
All
Component
classes now have aninteractive
parameter, which can beTrue
,False
, or (by default),None
.In the
Interface
class, input components haveinteractive
set toNone
, but output components set toFalse
Closes #925