Skip to content

Commit

Permalink
Forward the setup short-lived token Promise
Browse files Browse the repository at this point in the history
This caused a race condition not allowing the short-lived token to be returned in time before the setup finished.
  • Loading branch information
alextu committed Jun 17, 2024
1 parent 31ae356 commit bdc7162
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sources/src/develocity/build-scan.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export async function setup(config: BuildScanConfig): Promise<void> {
maybeExportVariableNotEmpty('GRADLE_PLUGIN_REPOSITORY_USERNAME', config.getGradlePluginRepositoryUsername())
maybeExportVariableNotEmpty('GRADLE_PLUGIN_REPOSITORY_PASSWORD', config.getGradlePluginRepositoryPassword())

setupToken(config.getDevelocityAccessKey(), config.getDevelocityTokenExpiry())
return setupToken(config.getDevelocityAccessKey(), config.getDevelocityTokenExpiry())
}

function maybeExportVariable(variableName: string, value: unknown): void {
Expand Down

0 comments on commit bdc7162

Please sign in to comment.