Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture task input files when plugin not applied #77

Merged
merged 6 commits into from
Mar 25, 2024
Merged

Capture task input files when plugin not applied #77

merged 6 commits into from
Mar 25, 2024

Conversation

welandaz
Copy link
Member

This PR changes the behavior such that task input files are captured when the environment variable is explicitly specified and for the cases when the plugin is not applied.

@welandaz welandaz requested review from bigdaz and alextu March 19, 2024 18:03
@welandaz welandaz self-assigned this Mar 19, 2024
@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Demo adding Build Scan® comment to PR :: failing-build-with-comment-on-failure
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
kotlin-dsl no-a-real-task 8.5 ❌ Build Scan PUBLISHED

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Demo adding Build Scan® comment to PR :: successful-build-with-always-comment
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
kotlin-dsl build 8.5 ✅ Build Scan PUBLISHED

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Demo adding Build Scan® comment to PR :: failing-build-with-comment-on-failure
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
kotlin-dsl no-a-real-task 8.5 ❌ Build Scan PUBLISHED

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Demo adding Build Scan® comment to PR :: successful-build-with-always-comment
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
kotlin-dsl build 8.5 ✅ Build Scan PUBLISHED

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Demo adding Build Scan® comment to PR :: successful-build-with-always-comment
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
kotlin-dsl build 8.5 ✅ Build Scan PUBLISHED

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Demo adding Build Scan® comment to PR :: failing-build-with-comment-on-failure
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
kotlin-dsl no-a-real-task 8.5 ❌ Build Scan PUBLISHED

bigdaz
bigdaz approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@bigdaz bigdaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.
However, can you please raise an issue describing the problem that is fixed by this PR, and the changed behaviour? That way it won't be missed from the release notes.

@welandaz welandaz linked an issue Mar 19, 2024 that may be closed by this pull request
Capture task input files when plugin is not applied #79
Closed
@welandaz
Copy link
Member Author

Changes LGTM. However, can you please raise an issue describing the problem that is fixed by this PR, and the changed behaviour? That way it won't be missed from the release notes.

Sure, I've created the issue and linked it.

@welandaz welandaz requested a review from alextu March 25, 2024 14:31
@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Demo adding Build Scan® comment to PR :: successful-build-with-always-comment
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
kotlin-dsl build 8.7 ✅ Build Scan PUBLISHED

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Demo adding Build Scan® comment to PR :: failing-build-with-comment-on-failure
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
kotlin-dsl no-a-real-task 8.7 ❌ Build Scan PUBLISHED

@welandaz welandaz merged commit c276584 into main Mar 25, 2024
246 of 249 checks passed
@welandaz welandaz deleted the welandaz/refine-task-input-files-capturing branch March 25, 2024 14:34
@bigdaz bigdaz added this to the v3.2 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erichaagdev erichaagdev erichaagdev left review comments

@bigdaz bigdaz bigdaz approved these changes

@alextu alextu Awaiting requested review from alextu

Assignees

@welandaz welandaz

Labels
None yet
Projects
None yet
Milestone
v3.2
Development

Successfully merging this pull request may close these issues.

Capture task input files when plugin is not applied
4 participants
@welandaz @bigdaz @alextu @erichaagdev