Migrate build logic to Kotlin DSL #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Haughton <3flex@users.noreply.github.com>
Signed-off-by: Matthew Haughton <3flex@users.noreply.github.com>
Signed-off-by: Matthew Haughton <3flex@users.noreply.github.com>
Signed-off-by: Matthew Haughton <3flex@users.noreply.github.com>
Signed-off-by: Matthew Haughton <3flex@users.noreply.github.com>
Signed-off-by: Matthew Haughton <3flex@users.noreply.github.com>
Goooler
approved these changes
Apr 5, 2024
| id("org.gradle.toolchains.foojay-resolver-convention") version "0.8.0" | ||
| } | ||
|
|
||
| val isCI = System.getenv("GITHUB_ACTIONS") != null |
There was a problem hiding this comment.
Suggested change
| val isCI = System.getenv("GITHUB_ACTIONS") != null | |
| val isCI = providers.environmentVariable("CI").isPresent |
| remote(develocity.buildCache) { | ||
| isEnabled = true | ||
| // Check access key presence to avoid build cache errors on PR builds when access key is not present | ||
| val accessKey = System.getenv("GRADLE_ENTERPRISE_ACCESS_KEY") |
There was a problem hiding this comment.
Suggested change
| val accessKey = System.getenv("GRADLE_ENTERPRISE_ACCESS_KEY") | |
| val accessKey = providers.environmentVariable("GRADLE_ENTERPRISE_ACCESS_KEY").isPresent |
| } | ||
|
|
||
| githubRelease { | ||
| token(System.getenv("CCUD_GIT_TOKEN") ?: "") |
There was a problem hiding this comment.
Suggested change
| token(System.getenv("CCUD_GIT_TOKEN") ?: "") | |
| token(providers.environmentVariable("CCUD_GIT_TOKEN").orNull.orEmpty()) |
|
Thanks for reviewing @Goooler, I've kept the scope to the minimum required to migrate to Kotlin DSL, but those would be good contributions for another PR. |
Co-authored-by: Clay Johnson <cjohnson@gradle.com> Signed-off-by: Matthew Haughton <3flex@users.noreply.github.com>
Signed-off-by: Matthew Haughton <3flex@users.noreply.github.com>
|
Fixed - I've also updated README in the last commit as there were a few references (and a link) to settings.gradle. Please check that before merging, thanks! |
clayburn
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #186
The diff from GitHub makes it hard to review, but the commit history should be clear.