Fixed empty PR branch custom value #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runningcode
reviewed
Apr 4, 2024
| @@ -248,7 +248,7 @@ private void execute() { | |||
| addCustomValueAndSearchLink(buildScan, "CI workflow", value)); | |||
| envVariable("GITHUB_RUN_ID").ifPresent(value -> | |||
| addCustomValueAndSearchLink(buildScan, "CI run", value)); | |||
| envVariable("GITHUB_HEAD_REF").ifPresent(value -> | |||
| envVariable("GITHUB_HEAD_REF").filter(value -> !value.isEmpty()).ifPresent(value -> | |||
There was a problem hiding this comment.
can we do the filter after the ifPresent check? since we wouldn't even need the filter if the value isn't present
There was a problem hiding this comment.
Sure, however, filter works on the Option<String>, so if that's empty it won't do anything. Should I still move it? If I move it in the ifPresent, I'll need to do something like if(!value.isEmpty()) buildScan.value("PR branch", value), which I think isn't as nice.
There was a problem hiding this comment.
oh i see, in that case does that mean the ifPresent isn't needed?
There was a problem hiding this comment.
It still is, the filter will return empty if the value doesn't pass the check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #215.
Scans after the fix:
export GITHUB_HEAD_REF=someBranch: scanexport GITHUB_HEAD_REF=: scan