Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mavenCentral badge in README.md #25

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

ribafish
Copy link
Member

@ribafish ribafish commented Apr 4, 2024

No description provided.

@ribafish ribafish requested a review from a team April 4, 2024 10:17
Copy link
Member

@runningcode runningcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this need to be changed every time we bump the sbt version?

@ribafish
Copy link
Member Author

ribafish commented Apr 4, 2024

will this need to be changed every time we bump the sbt version?

@runningcode, I believe we'd need to bump it on scala major.minor.* (patch doesn't matter) or sbt major.*.* (minor and patch don't matter) version changes. @gradle/ge-sbt, could you confirm?

Unfortunately, https://img.shields.io doesn't find it on mavenCentral without those, probably because that's the actual name published by sbt (with scala+sbt major versions).

@Duhemm
Copy link
Member

Duhemm commented Apr 4, 2024

The _2.12_1.0 is not expected to change for a very long time (the 1.0 suffix refers to the sbt version, not the Develocity sbt build agent version. The 2.12 suffix refers to the Scala version used to build the project)

@runningcode
Copy link
Member

Thanks for those details. Sounds like it should stay as is and we'll just have to remember to update it.

@ribafish ribafish merged commit f6026dc into main Apr 4, 2024
2 checks passed
@ribafish ribafish deleted the gk/readmeMavenCentralBadge branch April 4, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants