Use Develocity Maven extension #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshevche
approved these changes
Mar 14, 2024
leonard84
reviewed
Mar 14, 2024
welandaz
reviewed
Mar 14, 2024
src/test/java/com/gradle/develocity/bamboo/ArtifactoryMaven3TaskMavenOptsSetterTest.java
Show resolved
Hide resolved
alextu
approved these changes
Mar 18, 2024
src/test/java/com/gradle/develocity/bamboo/ArtifactoryMaven3TaskMavenOptsSetterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/gradle/develocity/bamboo/ArtifactoryMaven3TaskMavenOptsSetterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/gradle/develocity/bamboo/DefaultMavenOptsSetterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/gradle/develocity/bamboo/DefaultMavenOptsSetterTest.java
Outdated
Show resolved
Hide resolved
leonard84
approved these changes
Mar 18, 2024
Signed-off-by: Daniel Clausen <dclausen@gradle.com>
Only if neither the deprecated nor the new version of Maven extension is found, we want to add the embedded Maven extension to the class path. Signed-off-by: Daniel Clausen <dclausen@gradle.com>
Since this type is used for parameters of public methods, the visibility scope should be adjusted. Signed-off-by: Daniel Clausen <dclausen@gradle.com>
Older Maven extensions will simply ignore the new system properties. Newer Maven extensions will use the new system properties and therefore build will not produce deprecation warnings. Signed-off-by: Daniel Clausen <dclausen@gradle.com>
Signed-off-by: Daniel Clausen <dclausen@gradle.com>
This has been adjusted, because Develocity use terms-of-use instead of terms-of-service. Signed-off-by: Daniel Clausen <dclausen@gradle.com>
Signed-off-by: Daniel Clausen <dclausen@gradle.com>
…class Signed-off-by: Daniel Clausen <dclausen@gradle.com>
* the line for the v2.0.0 of the Bamboo plugin must remain unchanged * the line for "Next version" is the version released when DV 2024.1 and Maven extension 1.21 are released Signed-off-by: Daniel Clausen <dclausen@gradle.com>
Signed-off-by: Daniel Clausen <dclausen@gradle.com>
Signed-off-by: Daniel Clausen <dclausen@gradle.com>
snoopcheri
force-pushed
the
snoopcheri/33446-configure-develocity-plugin
branch
from
8b776fa
to
c435fe0
Compare
scans.gradle.org unfortunately does not accept RC versions of build agents. This change detects this case and makes sure that the test buildScanIsPublished still passes. Signed-off-by: Daniel Clausen <dclausen@gradle.com>
As soon as the Maven extension is released, we have to * update the embedded Maven extension version to a non-RC one * remove the Gradle-internal repositories * remove the hack in MavenInjectionTest which detects RC versions Signed-off-by: Daniel Clausen <dclausen@gradle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
1.21-rc-3Before this PR can be merged:
1.21once it is released (and remove Gradle's public repository as well)