Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore flakiness in :detekt-gradle-plugin:functionalTest #81

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

jprinet
Copy link
Member

@jprinet jprinet commented Nov 3, 2023

Issue

Detekt build is failing very often due to test failures in :detekt-gradle-plugin:functionalTest
See failure trends here

This issue has been fixed on Detekt by publishing the artifact to local repository.
See PR here
The fix consist of a 2 step build to publish first the artifacts in the local Maven repository.

Trying it in the experiments with a single invocation still fails
./gradlew publishToMavenLocal build -x detekt

Fix

Ignore the failing task

@jprinet jprinet assigned jprinet and runningcode and unassigned jprinet Nov 3, 2023
Copy link
Member

@runningcode runningcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context. Is it possible to add a dependency from the functionalTest on to the publishToMavenLocal to resolve this

@jprinet
Copy link
Member Author

jprinet commented Nov 6, 2023

Thanks for the context. Is it possible to add a dependency from the functionalTest on to the publishToMavenLocal to resolve this

It seems this was considered in the PR but actually got pushed back

@runningcode
Copy link
Member

Ok then let's go with this approach!

@jprinet jprinet merged commit 60009c2 into main Nov 7, 2023
1 check passed
@jprinet jprinet deleted the jprinet/fix-detekt-build branch November 7, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants