Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples-check should not export Groovy dependency #28

Closed
lptr opened this issue Sep 7, 2018 · 1 comment
Closed

samples-check should not export Groovy dependency #28

lptr opened this issue Sep 7, 2018 · 1 comment
Assignees
@eriwen

Comments

@lptr
Copy link
Member

lptr commented Sep 7, 2018

IIUC, Groovy is only used to test the project, so there should be no production dependency on Groovy at all.
@eriwen eriwen self-assigned this Sep 10, 2018
eriwen added a commit that referenced this issue Sep 10, 2018
@eriwen
Avoid exporting Groovy dependency since it's only used for testing
bfa5221 
Issue: #28
@eriwen
Copy link
Contributor

eriwen commented Sep 10, 2018

Fixed with bfa5221 and released with v0.6.1

@eriwen eriwen closed this as completed Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eriwen eriwen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eriwen @lptr