Add Sample rule that copies a sample to a directory for testing #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extracts a JUnit 4 TestRule from the Sample rule present in gradle/gradle and makes it reusable without relying on any Gradle specific classes.
wolfs
requested changes
Jul 5, 2018
| defaultSampleName); | ||
| } | ||
|
|
||
| private static SourceSampleDirSupplier eagerSourceSampleDirSupplier(final String sourceBaseDirPath) { |
There was a problem hiding this comment.
Eager doesn't seem to be the right name. How about rootDirSourceSampleDirProvider?
| this(sourceBaseDirPath, temporaryFolder, null); | ||
| } | ||
|
|
||
| public Sample(final String sourceBaseDirPath, final TemporaryFolder temporaryFolder, @Nullable String defaultSampleName) { |
There was a problem hiding this comment.
How about we don't expose a long/many constructors but some builder like methods instead? This way we can keep the API stable/extendable and the class is easier to use.
|
@wolfs PTAL! |
marcphilipp
force-pushed
the
marc/sample-rule
branch
from
8f7f9bf
to
0799d53
Compare
wolfs
approved these changes
Jul 6, 2018
|
@eriwen Would you like to take a look and potentially merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts a JUnit 4 TestRule from the Sample rule present in gradle/gradle and makes it reusable without relying on any Gradle specific classes.