-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small cleanups and test fixes #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are not used consistenty, so just remove them to be consistent again. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
It is the point of aliases to map deprecated identifiers. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
See https://docs.gradle.org/current/userguide/upgrading_version_7.html#for_use_at_configuration_time_deprecation. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
44e9c5f
to
acd6f11
Compare
The Foojay API changed to use "GraalVM" instead of "Graal VM" as the distribution name. While at it, make a check more strict by using `startsWith()` instead of `contains()`. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
"GraalVM Community" is the new name for "GraalVM CE X" going forward, and "GraalVM" is the name for a new Oracle distribution under the "GraalVM Free Terms and Conditions (GFTC) license", see https://medium.com/graalvm/a-new-graalvm-release-and-new-free-license-4aab483692f5 Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
jbartok
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.