Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete dependency-graph generated on build failure #115

Closed
bigdaz opened this issue Feb 12, 2024 · 0 comments
Closed

Incomplete dependency-graph generated on build failure #115

bigdaz opened this issue Feb 12, 2024 · 0 comments
Milestone
v1.2.2

Comments

@bigdaz
Copy link
Member

bigdaz commented Feb 12, 2024

When the build fails, in most cases a dependency-graph file is still generated. This can result in an incomplete dependency-graph being submitted, which could result in Dependabot Alerts being resolved incorrectly.

By default, the plugin should not generate an incomplete dependency-graph file in these circumstances. Instead, no file should be generated, and a warning emitted.

If it is deemed useful, we could add an opt-in to allow dependency-graph generation on failed builds.
@bigdaz bigdaz added this to the v1.2.2 milestone Feb 12, 2024
bigdaz added a commit that referenced this issue Feb 12, 2024
@bigdaz
Only write dependency-graph on build success
6ce888b 
Fixes #115
bigdaz added a commit that referenced this issue Feb 13, 2024
@bigdaz
Only write dependency-graph on build success
9e5f3a4 
Implementation uses "RunWork" build operation on Gradle 8.+,
and "buildFinished" on older versions.

Fixes #115
@bigdaz bigdaz closed this as completed in 5538f99 Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.2
Development

No branches or pull requests
1 participant
@bigdaz