Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometime the build scan url isn't extracted #26

Closed
lacasseio opened this issue Jul 19, 2020 · 2 comments
Closed

Sometime the build scan url isn't extracted #26

lacasseio opened this issue Jul 19, 2020 · 2 comments

Comments

@lacasseio
Copy link

There seems to be a problem in the logic here: https://github.com/eskatos/gradle-command-action/blob/master/src/execution.ts#L21-L30

It seems that the next line is sometimes empty which causes the publish URL scrapping to miss the real line with the URL. I can recommend extracting the first instance of a line starting with http. Alternatively, it could be the other check that fails where the line doesn't exactly start with HTTP. Unfortunately, there isn't enough logging to figure out where the failure is happening.

@lacasseio
Copy link
Author

Here is an example, the statuses mark with Details properly detected the build scan URL while the other ones have a build scan URL but weren't extracted:

Screen Shot 2020-07-19 at 1 04 40 PM

@eskatos
Copy link
Member

eskatos commented Sep 13, 2020

Hey Daniel 👋
Thanks for the report, I simplified the build scan url scraping.
Please try again and tell me how it goes, we'll reopen this issue if needed.

@eskatos eskatos closed this as completed Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants