Experiments can be run successfully when configuration caching is enabled #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mPropertiesArgs in initialization scripts
etiennestuder
requested changes
Mar 18, 2023
components/scripts/gradle/gradle-init-scripts/configure-gradle-enterprise.gradle
Show resolved
Hide resolved
components/scripts/gradle/gradle-init-scripts/configure-gradle-enterprise.gradle
Show resolved
Hide resolved
components/scripts/gradle/gradle-init-scripts/configure-gradle-enterprise.gradle
Show resolved
Hide resolved
components/scripts/gradle/gradle-init-scripts/configure-gradle-enterprise.gradle
Outdated
Show resolved
Hide resolved
components/scripts/gradle/gradle-init-scripts/configure-gradle-enterprise.gradle
Outdated
Show resolved
Hide resolved
etiennestuder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a second attempt at PR #361. It's description is still entirely valid.
However, it introduced new issue for projects using configuration caching. It was since reverted from
main.This PR solves the original issue in a way that is compatible with configuration caching.
See also this successful execution of the cross-platform tests using this branch: https://github.com/gradle/gradle-enterprise-build-validation-scripts/actions/runs/4451911328