New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce redundant properties related to the platform or target #963
Comments
We should certainly replace If we get rid of |
from planning... 👍 CppPlatform/SwiftPlatform should represent the language details/target. |
related #399 |
What I set off implementing for this issue is to break the polymorphism between |
I created a PR regarding the above: gradle/gradle#8222 |
The only other property that is shared with the software model is the |
@lacasseio I took a look at the PR and I think you're close to what I was imagining. I think we should go with something like:
My expectation is that you could have many target platforms that have similar target machines (e.g., only differ with SDK/language levels). I'd suggest a couple of tweaks:
This makes WDYT? |
I think I got it, let me do some change to the PR. |
@big-guy I pushed some changes to reflect your comments. What do you think about the changes? |
I find |
We don't currently expose the
TargetMachine
used by the binary, but we do have a "target platform" (using software model types) that are extended by the C++ plugin asCppPlatform
. This is somewhat the same thing asTargetMachine
.I think we want to expose
TargetMachine
inComponentWithNativeRuntime
and hideNativePlatform
(we'll need it to work with the existing tasks). We may be able to get rid ofCppPlatform
entirely.We should consider how this affects our samples that demonstrate target machine specific dependencies.
The text was updated successfully, but these errors were encountered: