Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to skip warmup builds despite --warmups=0 #43

Closed
wisechengyi opened this issue Aug 10, 2017 · 5 comments
Closed

unable to skip warmup builds despite --warmups=0 #43

wisechengyi opened this issue Aug 10, 2017 · 5 comments
Labels

Comments

@wisechengyi
Copy link

No description provided.

@oehme
Copy link
Contributor

oehme commented Aug 10, 2017

Could you elaborate what use case you have for 0 warmups?

@wisechengyi
Copy link
Author

wisechengyi commented Aug 10, 2017

Sure! In a separate thread, we were trying to figure out what the performance issue is for gradle after git clean -fdx in the android repo. The issue only occurs on the first run, because the second run will be all up to date. In this case, having 'clean' task as the clean up task does not work because ./gradlew clean isn't the same as git clean -fdx

It does make sense to me that warmups has a non zero default value, but since it is an option, specifying --warmups=0 should work as expected as well.

@oehme
Copy link
Contributor

oehme commented Aug 10, 2017

I remember the problem you were looking for was in buildSrc. The Gradle profiler will already start up Gradle to determine what version you are running on and what extra JVM args your build specifies. So buildSrc will already be warmed up, even before the first "warmup run".

I think for analysing this special case, you might want to add the agentpath for JProfiler/YourKit to the Gradle JVM args by hand and profile "the old fashioned way". The Gradle profiler isn't really suited for this kind of "first use" analysis at the moment.

@wisechengyi
Copy link
Author

wisechengyi commented Aug 10, 2017

I understand. Although my second point should be still valid, i.e. it makes sense for warmup to have non zero default, but there is no need to force warmup runs, and --warmups=0should not surprise people.

@oehme oehme added the bug label Mar 14, 2018
pvliss added a commit to pvliss/gradle-profiler that referenced this issue Jan 23, 2019
Issue gradle#43

Signed-off-by: Panayiotis Vlissidis <pvlissidis@gmail.com>
pvliss added a commit to pvliss/gradle-profiler that referenced this issue Jan 23, 2019
…ithout warm-ups

Issue gradle#43

Signed-off-by: Panayiotis Vlissidis <pvlissidis@gmail.com>
pvliss added a commit to pvliss/gradle-profiler that referenced this issue Jan 23, 2019
…ithout warm-ups

Issue gradle#43

Signed-off-by: Panayiotis Vlissidis <pvlissidis@gmail.com>
oehme added a commit that referenced this issue Mar 8, 2019
Fail at the configuration stage when trying to profile or benchmark without warm-ups
@oehme oehme closed this as completed Mar 8, 2019
@charlesritchea
Copy link

@oehme My use case is simple. My build takes a long time (long running e2e test), so I don't want to run it more than once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants