Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scenarios to use different commands than build #197

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

bmuskalla
Copy link
Contributor

No description provided.

@bmuskalla bmuskalla requested a review from wolfs March 16, 2020 20:54
@wolfs wolfs assigned wolfs and bmuskalla and unassigned wolfs Mar 16, 2020
Copy link
Member

@wolfs wolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. I must admit I don't have much idea what you are doing, though.

@lptr
Copy link
Member

lptr commented Mar 17, 2020

This will break existing scenarios, right?

@bmuskalla
Copy link
Contributor Author

Exactly. Do you know any scenario files that use Bazel and would require updating?

@lptr
Copy link
Member

lptr commented Mar 17, 2020

I don't know of anything we publish that'd need to be updated. This has never been updated to include Bazel: https://github.com/gradle/perf-android-large

@bmuskalla
Copy link
Contributor Author

That's something I might do at some point in the future though. So given nobody is using gradle-profiler using bazel scenarios right now, are we good with breaking people? Do we need to announce this in some way?

@bmuskalla
Copy link
Contributor Author

Totally forgot about this one. So it seems no one (except myself) is using the bazel support, so no harm done breaking the compatibility. Going to merge this after rebasing if nobody objects.

@bmuskalla bmuskalla merged commit 5976852 into master Mar 30, 2020
@bmuskalla bmuskalla deleted the bmuskalla/bazelCommand branch March 30, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants