Fix Kotlin non-abi-change mutator so it produces a non-abi-change for java consumers #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lptr
reviewed
Jul 17, 2020
src/main/java/org/gradle/profiler/mutations/AbstractFileChangeMutator.java
Outdated
Show resolved
Hide resolved
...t/groovy/org/gradle/profiler/mutations/ApplyNonAbiChangeToKotlinSourceFileMutatorTest.groovy
Outdated
Show resolved
Hide resolved
Changing the signature of a private function changes kotlin metadata hence not producing a non-abi-change but an abi-change for Java consumers. This commit lets the Kotlin mutator inject a dummy method before running a scenario, and only modify it's implementation body on each build. Signed-off-by: Paul Merlin <paul@gradle.com>
eskatos
force-pushed
the
eskatos/kotlin/fix-non-abi-mutator
branch
from
58505e6
to
1a583ff
Compare
Signed-off-by: Paul Merlin <paul@gradle.com>
|
This is what I get before the fix:
This is what I get after the fix:
Looks like it worked. (I also have no idea how build times can increase without the fix, but that's probably a bug in Kotlin.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the signature of a private function changes kotlin metadata hence not producing a non-abi-change but an abi-change for java consumers.
This commit lets the Kotlin mutator inject a dummy method before running a scenario, and modify it's implementation body on each build.
See #212