Fix PID instrumentation for configuration caching #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on Gradle versions >= 6.1, so the PID collector is compatible with configuration caching.
wolfs
changed the title
wolfs
commented
Sep 3, 2020
| GFileUtils.writeFile(getPid().toString(), getParameters().getPidFile().get().getAsFile()); | ||
| } | ||
|
|
||
| private Integer getPid() throws NoSuchFieldException, IllegalAccessException, NoSuchMethodException, InvocationTargetException { |
There was a problem hiding this comment.
I am not very happy with how we obtain the PID of the current process here, though I don't have a better idea :(.
There was a problem hiding this comment.
I guess no better solution on Java 8.
blindpirate
reviewed
Sep 4, 2020
| @@ -16,7 +16,7 @@ abstract class AbstractProfilerIntegrationTest extends Specification { | |||
| "3.3", "3.4.1", "3.5", | |||
| "4.0", "4.1", "4.2.1", "4.7", | |||
| "5.2.1", "5.5.1", "5.6.3", | |||
| "6.0.1", "6.1", "6.6-rc-2" | |||
| "6.0.1", "6.1", "6.6" | |||
There was a problem hiding this comment.
Done. I also upgradled the build to 6.6.1.
blindpirate
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a build service for PID instrumentation on Gradle versions >= 6.1, so the PID collector is
compatible with configuration caching.